Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Jan 29, 2026

@not-matthias not-matthias force-pushed the cod-2106-support-memory-profiling-for-nodejs branch 2 times, most recently from bce195c to 36abf5e Compare January 29, 2026 18:57
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 29, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 20.92%

Comparing cod-2106-support-memory-profiling-for-nodejs (86299a6) with main (4b39225)

Summary

⚡ 3 improved benchmarks
❌ 1 regressed benchmark
✅ 134 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_iterative_fibo_10 546.7 µs 299.7 µs +82.41%
Simulation wait 500ms 9.8 ms 12.4 ms -20.92%
WallTime short body 1.9 µs 1.6 µs +13.97%
WallTime short body 2.1 µs 1.8 µs +17.81%

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olgtm

@adriencaccia adriencaccia force-pushed the main branch 3 times, most recently from 841368c to 48f7af2 Compare February 3, 2026 17:30
@not-matthias not-matthias force-pushed the cod-2106-support-memory-profiling-for-nodejs branch 8 times, most recently from 590b165 to 946ebfe Compare February 9, 2026 10:02
@not-matthias not-matthias force-pushed the cod-2106-support-memory-profiling-for-nodejs branch from 946ebfe to 86299a6 Compare February 9, 2026 10:17
@not-matthias not-matthias merged commit 86299a6 into main Feb 9, 2026
17 of 18 checks passed
@not-matthias not-matthias deleted the cod-2106-support-memory-profiling-for-nodejs branch February 9, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants